Close all panels originated by the extension when extension unloads.

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/string_number_conversions.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/net/url_request_mock_util.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 #include "chrome/browser/ui/panels/panel_settings_menu_model.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/download/download_manager.h"
 #include "content/browser/net/url_request_mock_http_job.h"
 #include "content/browser/tab_contents/tab_contents.h"
+#include "content/public/browser/notification_service.h"
 #include "content/public/common/url_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class PanelBrowserTest : public BasePanelBrowserTest {
  public:
   PanelBrowserTest() : BasePanelBrowserTest() {
   }
 
  protected:
   void CloseWindowAndWait(Browser* browser) {
@@ skipping 1268 matching lines @@
   EXPECT_EQ(Panel::MINIMIZED, panel1->expansion_state());
 
   // Another check for the same.
   EXPECT_FALSE(panel1->IsActive());
   EXPECT_FALSE(panel2->IsActive());
 
   panel1->Close();
   panel2->Close();
 }
 
+IN_PROC_BROWSER_TEST_F(PanelBrowserTest,
+                       NonExtensionDomainPanelsCloseOnUninstall) {
+  // Create a test extension.
+  DictionaryValue empty_value;
+  scoped_refptr<Extension> extension =
+      CreateExtension(FILE_PATH_LITERAL("TestExtension"),
+      Extension::INVALID, empty_value);
+  std::string extension_app_name =
+      web_app::GenerateApplicationNameFromExtensionId(extension->id());
+
+  PanelManager* panel_manager = PanelManager::GetInstance();
+  EXPECT_EQ(0, panel_manager->num_panels());
+
+  // Create a panel with the extension as host.
+  CreatePanelParams params(extension_app_name, gfx::Rect(), SHOW_AS_INACTIVE);
+  std::string extension_domain_url(chrome::kExtensionScheme);
+  extension_domain_url += "://";
+  extension_domain_url += extension->id();
+  extension_domain_url += "/hello.html";
+  params.url = GURL(extension_domain_url);
+  CreatePanelWithParams(params);
+  EXPECT_EQ(1, panel_manager->num_panels());
+
+  // Create a panel with a non-extension host.
+  CreatePanelParams params1(extension_app_name, gfx::Rect(), SHOW_AS_INACTIVE);
+  params1.url = GURL(chrome::kAboutBlankURL);
+  CreatePanelWithParams(params1);
+  EXPECT_EQ(2, panel_manager->num_panels());
+
+  // Create another extension and a panel from that extension.
+  scoped_refptr<Extension> extension_other =
+      CreateExtension(FILE_PATH_LITERAL("TestExtensionOther"),
+      Extension::INVALID, empty_value);
+  std::string extension_app_name_other =
+      web_app::GenerateApplicationNameFromExtensionId(extension_other->id());
+  Panel* panel_other = CreatePanel(extension_app_name_other);
+
+  // Send unload notification on the first extension and wait for count of
+  // panels to go down to 1.
+  UnloadedExtensionInfo details(extension,
+                                extension_misc::UNLOAD_REASON_UNINSTALL);
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_EXTENSION_UNLOADED,
+      content::Source<Profile>(browser()->profile()),
+      content::Details<UnloadedExtensionInfo>(&details));
+  while (panel_manager->num_panels() != 1)
+    MessageLoopForUI::current()->RunAllPending();

[Paweł Hajdan Jr., 2011/10/25 09:01:38]

NOOOOOO! Don't do that please, it's known to be bad. Please wait for an event
instead. Don't RunAllPending in a loop.

[prasadt, 2011/10/25 17:29:28]

Spooky response for something that seems to be done all over the code.
Halloween? :-)
git grep -B 4 RunAllPending | less
Done. As it turns out, this is easy enough to do this with wait on existing
notifications.
Thanks.

+
+  // Verify that the panel that's left is the panel from the second extension.
+  EXPECT_EQ(panel_other, panel_manager->panels()[0]);
+  panel_other->Close();
+}
+
 class PanelDownloadTest : public PanelBrowserTest {
  public:
   PanelDownloadTest() : PanelBrowserTest() { }
 
   // Creates a temporary directory for downloads that is auto-deleted
   // on destruction.
   bool CreateDownloadDirectory(Profile* profile) {
     bool created = downloads_directory_.CreateUniqueTempDir();
     if (!created)
       return false;
@@ skipping 154 matching lines @@
   EXPECT_EQ(1, tabbed_browser->tab_count());
   ASSERT_TRUE(tabbed_browser->window()->IsDownloadShelfVisible());
   tabbed_browser->CloseWindow();
 #endif
 
   EXPECT_EQ(1, panel_browser->tab_count());
   ASSERT_FALSE(panel_browser->window()->IsDownloadShelfVisible());
 
   panel_browser->CloseWindow();
 }