Issue 8387005: Fixes to build chrome under chroot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8387005: Fixes to build chrome under chroot. (Closed)

Created:
9 years, 2 months ago by Emmanuel Saint-loubert-Bié

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, Peng

CC:
chromium-reviews, tfarina, James Su, dhollowa, kliegs

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes to build chrome under chroot: 1) Added missing headers causing compilation errors 2) Added an #ifdef to prevent the case of a dangling else{} without a preceeding if(){}. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106997

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	views/ime/input_method_ibus.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	views/ime/input_method_ibus.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peng

On 2011/10/24 22:20:11, Emmanuel Saint-loubert wrote: > Please take a look Peng. Thanks! lgtm. thx.

9 years, 2 months ago (2011-10-24 22:27:03 UTC) #2

No LGTM from valid reviewers yet.

Expand Messages | Collapse Messages