chrome/browser/speech/extension_speech_input_api_constants.h - Issue 8386074: Add a tray notification UI for speech input recording in the extension API.

Side by Side Diff: chrome/browser/speech/extension_speech_input_api_constants.h

Issue 8386074: Add a tray notification UI for speech input recording in the extension API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixing one missing include for moving the API. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/speech/extension_speech_input_api.h ('K') | « chrome/browser/speech/extension_speech_input_api.cc ('k') | chrome/browser/speech/extension_speech_input_api_constants.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_EXTENSIONS_SPEECH_INPUT_EXTENSION_SPEECH_INPUT_API_CONSTA NTS_H_	5 #ifndef CHROME_BROWSER_SPEECH_EXTENSION_SPEECH_INPUT_API_CONSTANTS_H_
	Aaron Boodman 2011/11/06 22:55:38 There's no need for these separate 'constants' fil There's no need for these separate 'constants' files anymore. They are an artifact of some requirements we had once upon a time but no longer do. Can you move these constants into an anonymous namespace of speech_input_extension_api.cc? If you need to expose a few to the manager class, you can expose them in the speech_input_extension_api.h file. Leandro Graciá Gil 2011/11/07 17:11:43 Done. Show quoted text On 2011/11/06 22:55:38, Aaron Boodman wrote: > There's no need for these separate 'constants' files anymore. They are an > artifact of some requirements we had once upon a time but no longer do. > > Can you move these constants into an anonymous namespace of > speech_input_extension_api.cc? If you need to expose a few to the manager class, > you can expose them in the speech_input_extension_api.h file. Done.
6 #define CHROME_BROWSER_EXTENSIONS_SPEECH_INPUT_EXTENSION_SPEECH_INPUT_API_CONSTA NTS_H_	6 #define CHROME_BROWSER_SPEECH_EXTENSION_SPEECH_INPUT_API_CONSTANTS_H_

7	7

8 namespace extension_speech_input_api_constants {	8 namespace extension_speech_input_api_constants {

9	9

10 extern const char kLanguageKey[];	10 extern const char kLanguageKey[];

11 extern const char kGrammarKey[];	11 extern const char kGrammarKey[];

12 extern const char kFilterProfanitiesKey[];	12 extern const char kFilterProfanitiesKey[];

13	13

14 extern const char kErrorNoRecordingDeviceFound[];	14 extern const char kErrorNoRecordingDeviceFound[];

15 extern const char kErrorRecordingDeviceInUse[];	15 extern const char kErrorRecordingDeviceInUse[];

16 extern const char kErrorUnableToStart[];	16 extern const char kErrorUnableToStart[];

(...skipping 14 matching lines...) Expand all Loading...
31 extern const char kOnErrorEvent[];	31 extern const char kOnErrorEvent[];

32 extern const char kOnResultEvent[];	32 extern const char kOnResultEvent[];

33 extern const char kOnSoundStartEvent[];	33 extern const char kOnSoundStartEvent[];

34 extern const char kOnSoundEndEvent[];	34 extern const char kOnSoundEndEvent[];

35	35

36 extern const char kDefaultGrammar[];	36 extern const char kDefaultGrammar[];

37 extern const bool kDefaultFilterProfanities;	37 extern const bool kDefaultFilterProfanities;

38	38

39 } // namespace extension_speech_input_api_constants.	39 } // namespace extension_speech_input_api_constants.

40	40

41 #endif // CHROME_BROWSER_EXTENSIONS_SPEECH_INPUT_EXTENSION_SPEECH_INPUT_API_CON STANTS_H_	41 #endif // CHROME_BROWSER_SPEECH_EXTENSION_SPEECH_INPUT_API_CONSTANTS_H_

OLD	NEW