Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 8386072: Fix gcc-4.6 warnings. (Closed)

Created:
9 years, 1 month ago by Steven
Modified:
9 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix gcc-4.6 warnings. BUG=v8:1806 Committed: http://code.google.com/p/v8/source/detail?r=9867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -114 lines) Patch
M src/runtime.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 50 chunks +64 lines, -64 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 11 chunks +20 lines, -20 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Steven
PTAL.
9 years, 1 month ago (2011-11-03 08:31:29 UTC) #1
Jakob Kummerow
9 years, 1 month ago (2011-11-03 08:40:57 UTC) #2
LGTM.

I'm tempted to just disable the unused-but-set warning for cctests...

Powered by Google App Engine
This is Rietveld 408576698