Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 8386037: Remove the forward-bailout stack from the non-optimizing compiler. (Closed)

Created:
9 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 1 month ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Remove the forward-bailout stack from the non-optimizing compiler. This was pretty heavyweight. It was kept in just for a few corner cases that assumed it was there. We can work around them by making sure that the expression in a reified test context is always really the expression that was visited in that context; and by inspecting the context manually and consing up a pair of extra AST IDs for the unusual case of unary not in a value AST context. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -369 lines) Patch
M src/arm/full-codegen-arm.cc View 58 chunks +133 lines, -98 lines 0 comments Download
M src/ast.h View 2 chunks +18 lines, -1 line 0 comments Download
M src/full-codegen.h View 9 chunks +19 lines, -37 lines 0 comments Download
M src/full-codegen.cc View 11 chunks +25 lines, -44 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 57 chunks +138 lines, -84 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 19 chunks +19 lines, -19 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 59 chunks +139 lines, -84 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 1 month ago (2011-11-02 16:41:04 UTC) #1
fschneider
9 years, 1 month ago (2011-11-02 16:53:02 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698