Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: runtime/bin/socket_stream.dart

Issue 8386029: Consistently use setters to set event handlers in native APIs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/socket_impl.dart ('k') | samples/chat/http_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_stream.dart
diff --git a/runtime/bin/socket_stream.dart b/runtime/bin/socket_stream.dart
index 4b37c3af1ec52afc59013627dd56fb328d9fb9c0..a5982ced29a50b8bace189b67680688aa28a5c7f 100644
--- a/runtime/bin/socket_stream.dart
+++ b/runtime/bin/socket_stream.dart
@@ -41,15 +41,15 @@ class SocketInputStream implements InputStream {
}
void set dataHandler(void callback()) {
- _socket.setDataHandler(callback);
+ _socket.dataHandler = callback;
}
void set closeHandler(void callback()) {
- _socket.setCloseHandler(callback);
+ _socket.closeHandler = callback;
}
void set errorHandler(void callback()) {
- _socket.setErrorHandler(callback);
+ _socket.errorHandler = callback;
}
Socket _socket;
@@ -105,8 +105,8 @@ class _BufferList2 {
class SocketOutputStream implements OutputStream {
SocketOutputStream(Socket socket)
: _socket = socket, _pendingWrites = new _BufferList2() {
- _socket.setWriteHandler(_writeHandler);
- _socket.setErrorHandler(_errorHandler);
+ _socket.writeHandler = _writeHandler;
+ _socket.errorHandler = _errorHandler;
}
bool write(List<int> buffer) {
@@ -126,7 +126,7 @@ class SocketOutputStream implements OutputStream {
}
void close() {
- _socket.setWriteHandler(null);
+ _socket.writeHandler = null;
_pendingWrites.clear();
_socket.close();
_ended = true;
@@ -134,15 +134,15 @@ class SocketOutputStream implements OutputStream {
void set noPendingWriteHandler(void callback()) {
_noPendingWriteHandler = callback;
- _socket.setWriteHandler(_writeHandler);
+ _socket.writeHandler = _writeHandler;
}
void set closeHandler(void callback()) {
- _socket.setCloseHandler(callback());
+ _socket.closeHandler = callback;
}
void set errorHandler(void callback()) {
- _streamErrorHandler = callback();
+ _streamErrorHandler = callback;
}
bool _write(List<int> buffer, int offset, int len, bool copyBuffer) {
@@ -167,7 +167,7 @@ class SocketOutputStream implements OutputStream {
}
void _writeHandler() {
- _socket.setWriteHandler(_writeHandler);
+ _socket.writeHandler = _writeHandler;
// Write as much buffered data to the socket as possible.
while (!_pendingWrites.isEmpty()) {
List<int> buffer = _pendingWrites.first;
« no previous file with comments | « runtime/bin/socket_impl.dart ('k') | samples/chat/http_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698