Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 8386007: Used use-gl=any instead of forcing osmesa for UI tests. (Closed)

Created:
9 years, 1 month ago by alokp
Modified:
9 years, 1 month ago
Reviewers:
Lei Zhang, Zhenyao Mo
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Used use-gl=any instead of forcing osmesa for UI tests. This was committed in r106327 but reverted due to tsan failures. r107459 may have resolved tsan issues. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -41 lines) Patch
M chrome/test/gpu/webgl_conformance_tests.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 4 chunks +2 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
alokp
9 years, 1 month ago (2011-11-01 17:06:33 UTC) #1
Zhenyao Mo
9 years, 1 month ago (2011-11-01 18:49:33 UTC) #2
On 2011/11/01 17:06:33, Alok Priyadarshi wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698