Issue 8385001: Stop audio streams in all codepaths that need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8385001: Stop audio streams in all codepaths that need it. (Closed)

Created:
9 years, 2 months ago by Ami GONE FROM CHROMIUM

Modified:
9 years, 2 months ago

Reviewers:
enal1, enal

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Stop audio streams in all codepaths that need it. Before we were leaving dangling streams un-Stop()'d, causing delayed messages to eventually crash the browser when their source_callback_ was followed but already invalid. BUG=101228 TEST=trybots, manual testing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107000

Patch Set 1 #

Patch Set 2 : enal CR response. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -11 lines)			Patch
	M	media/audio/audio_output_controller.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	media/audio/audio_output_controller.cc	View	1	6 chunks	+17 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

enal1

LGTM Can you move if (stream) { Stop(), Close(), stream = NULL } into separate ...

9 years, 2 months ago (2011-10-24 19:54:13 UTC) #2

Ami GONE FROM CHROMIUM

> Can you move if (stream) { Stop(), Close(), stream = NULL } into separate ...

9 years, 2 months ago (2011-10-24 22:31:29 UTC) #3

LGTM once again.

Expand Messages | Collapse Messages