Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 8384021: MIPS: Use 8-byte alignment on native MIPS targets in Zone allocations. (Closed)

Created:
9 years, 1 month ago by kisg
Modified:
9 years, 1 month ago
Reviewers:
Paul Lind, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Use 8-byte alignment on native MIPS targets in Zone allocations. MIPS requires an 8-byte alignment for all allocated memory pointers. This fixes mjsunit div-mod on MIPS HW with --stress-opt --always-opt. BUG= TEST=

Patch Set 1 #

Patch Set 2 : Rebased on r9892 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/zone.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kisg
Please land the following commits together to avoid build errors: http://codereview.chromium.org/8384021/ http://codereview.chromium.org/8428004/ http://codereview.chromium.org/8387044/ http://codereview.chromium.org/8432010/ Thank ...
9 years, 1 month ago (2011-10-31 20:25:10 UTC) #1
danno
Please remove the platform-specific #if def, let's use 8-byte alignment for all platforms. After talking ...
9 years, 1 month ago (2011-11-09 12:01:48 UTC) #2
danno
Take that back. Erik is doing some analysis about zone allocation size, let's wait until ...
9 years, 1 month ago (2011-11-09 12:18:52 UTC) #3
danno
Erik Corry landed a patch that ensures that allocation that are increments of 8-byte are ...
9 years, 1 month ago (2011-11-17 13:29:09 UTC) #4
kisg
9 years, 1 month ago (2011-11-17 22:50:15 UTC) #5
On 2011/11/17 13:29:09, danno wrote:
> Erik Corry landed a patch that ensures that allocation that are increments of
> 8-byte  are 8-byte aligned. If that is sufficient to make this patch
> unnecessary, please close this issue. Otherwise let me know.

Yes, thank you, we were testing it on MIPS and it works fine. closing the issue.

Powered by Google App Engine
This is Rietveld 408576698