Chromium Code Reviews Chromium Code Reviews
Issue
8384020:
Close new bubbles on deactivate; disable rendering Chrome inactive. (Closed)
DescriptionClose new bubbles on deactivate; disable rendering Chrome inactive.
Implement WidgetFocusChangeListener, close on deactivate.
DisableInactiveRendering on the parent's top level widget.
Notify widgets without non-client views of activation changes.
To ensure bubble owners get the first click event that closes the bubble:
Stop explicitly setting the owner as the foreground window on close.
To ensure that removing this code didn't regress crbug.com/75610:
Add WS_POPUP for modal dialogs and re-enable owners on close (allowing OS activation).
Note: Showing bubbles long after CreateBubble might break DisableInactiveRendering.
BUG=97248, 98312
TEST=views_examples bubbles close on deactivate, example window never appears deactivated.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108912
Patch Set 1 : Disable inactive rendering of Chrome with new bubbles. #Patch Set 2 : Attempt close on loss of focus. #Patch Set 3 : Implement WidgetFocusChangeListener instead. #
Total comments: 4
Patch Set 4 : Implement Widget::Observer instead. #Patch Set 5 : Fix Window style, activation notification, and dialog owner enabling on close. #Patch Set 6 : Tentative test fix. #Patch Set 7 : Remove the WS_POPUP style for non-modal dialogs. #
Messages
Total messages: 6 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
