Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

Issue 8384012: Make some ErrorCode-s compile-time errors and some just type warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changes for comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java b/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java
index 1fdb007f3613538199a0a6a263ffeace1b769b9b..6af78affb2dada74c87410f12940b6059595aefa 100644
--- a/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java
+++ b/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java
@@ -57,6 +57,10 @@ public class SupertypeResolver {
supertype.getClass(); // Quick null check.
}
if (supertype != null) {
+ // TODO(scheglov) check for "extends/implements Dynamic"
+ /*if (supertype == typeProvider.getDynamicType()) {
+ topLevelContext.onError(superclassNode, ResolverErrorCode.EXTENDS_DYNAMIC, node.getName());
+ }*/
classElement.setSupertype(supertype);
} else {
assert classElement.getName().equals("Object") : classElement;
@@ -80,7 +84,11 @@ public class SupertypeResolver {
DartTypeNode boundNode = typeParameterNode.getBound();
Type bound;
if (boundNode != null) {
- bound = classContext.resolveType(boundNode, false);
+ bound =
+ classContext.resolveType(
+ boundNode,
+ false,
+ ResolverErrorCode.NO_SUCH_TYPE);
boundNode.setType(bound);
} else {
bound = typeProvider.getObjectType();

Powered by Google App Engine
This is Rietveld 408576698