Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

Issue 8384012: Make some ErrorCode-s compile-time errors and some just type warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changes for comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
index 94f7751a9414bae2083a625fda688227f1e35a12..b1dc41a05bb99e26f403a09e58b90014dde64948 100644
--- a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
+++ b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
@@ -95,7 +95,7 @@ public class MemberBuilder {
for (DartParameter parameter : node.getParameters()) {
parameters.add((VariableElement) parameter.accept(this));
}
- Type returnType = resolveType(node.getReturnTypeNode(), false);
+ Type returnType = resolveType(node.getReturnTypeNode(), false, TypeErrorCode.NO_SUCH_TYPE);
ClassElement functionElement = getTypeProvider().getFunctionType().getElement();
element.setFunctionType(Types.makeFunctionType(getContext(), functionElement,
parameters, returnType, null));
@@ -148,7 +148,7 @@ public class MemberBuilder {
isStatic = true;
}
}
- Type type = resolveType(node.getTypeNode(), isStatic);
+ Type type = resolveType(node.getTypeNode(), isStatic, TypeErrorCode.NO_SUCH_TYPE);
for (DartField fieldNode : node.getFields()) {
if (fieldNode.getModifiers().isAbstractField()) {
buildAbstractField(fieldNode);
@@ -185,7 +185,12 @@ public class MemberBuilder {
}
}
@Override public Element visitIdentifier(DartIdentifier node) {
- return context.resolveType(node, node, null, true).getElement();
+ return context.resolveType(
+ node,
+ node,
+ null,
+ true,
+ ResolverErrorCode.NO_SUCH_TYPE_CONSTRUCTOR).getElement();
}
@Override public Element visitParameterizedNode(DartParameterizedNode node) {
Element element = node.getExpression().accept(this);

Powered by Google App Engine
This is Rietveld 408576698