Make some ErrorCode-s compile-time errors and some just type warnings

compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

Index: compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java b/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java
index df36347c0f16371dafa997890b1fa9683cb9d34f..fdbf83d728a5c459f0b6d2baaeb87b71416e2df6 100644
--- a/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java
+++ b/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java
@@ -26,7 +26,11 @@ public enum TypeErrorCode implements ErrorCode {
   MEMBER_IS_A_CONSTRUCTOR("%s is a constructor in %s"),
   MISSING_ARGUMENT("missing argument of type %s"),
   MISSING_RETURN_VALUE("no return value; expected a value of type %s"),
-  NO_SUCH_TYPE("no such type \"%s\""),
+  NO_SUCH_TYPE_FIELD("no such type \"%s\" in field declaration"),
+  NO_SUCH_TYPE_GENERICS_ARGUMENT("no such type \"%s\" in type arguments"),

[zundel, 2011/10/31 19:00:28]

nit: could you add the name of the type at the end

no such type "foo" in type arguments for "bar"

+  NO_SUCH_TYPE_PARAMETER("no such type \"%s\" in method parameter"),

[zundel, 2011/10/31 19:00:28]

nit: again, could you add the name of the method parameter?  I won't keep
asking, just look at these two and add them if its easy to do.  The reason I ask
is that it might be helpful to test error messages.

[scheglov, 2011/10/31 20:48:06]

  I think now that may be having specific NO_SUCH_TYPE_* is mistake.
  For sure we need separate ErrorCode-s for warning and error, but not
return/parameter/variable/etc. This does not happen for Java in Eclipse. This is
not required at all for IDE - you just see where is problem. And more words in
error message is worse, not better. As of tests, I think that line number is
enough narrow location of problem.

[zundel, 2011/11/01 13:54:37]

As a counter point, if you look at NO_SUCH_TYPE_GENERICS_ARGUMENT error message
when it is printed out from the compiler, the error is highlighted on the
generic type, not the type parameter. We should probably fix that, but such
terse errors have confounded me many a time.  

I think the more precise errors are of benefit to the command line compiler,
especially for unit testing, and in at least some cases in the IDE, especially
if we expanded them still further to include the name of the entity they
reference.  Looking at the structure of the code, I see that is kind of
difficult, so you can ignore these comments.

+  NO_SUCH_TYPE_RETURN("no such type \"%s\" in method return"),

[zundel, 2011/11/01 13:54:37]

I agree this one is kind of silly.

+  NO_SUCH_TYPE_VARIABLE_STATEMENT("no such type \"%s\" in variable declaration statement"),

[zundel, 2011/11/01 13:54:37]

This one might be too.

   NOT_A_MEMBER_OF("\"%s\" is not a member of %s"),
   NOT_A_METHOD_IN("\"%s\" is not a method in %s"),
   NOT_A_FUNCTION("\"%s\" is not a function"),