tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart - Issue 8384012: Make some ErrorCode-s compile-time errors and some just type warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart

Issue 8384012: Make some ErrorCode-s compile-time errors and some just type warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use single NO_SUCH_TYPE (but separate for type warning and compile-time error), tweak tests Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java ('K') | « tests/language/language.status ('k') | tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart » ('j') | tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.

4

5 Map<String> foo; // Error: Map takes 2 type arguments.
zundel 2011/11/01 20:03:03 I think the right thing to do is to make this a po I think the right thing to do is to make this a positive test, given the clarification by Gilad, and then convert this one to be an example where the wrong number of argument is a compile-time error, say 'new Foo<param1, param2>' where Foo is only declared to take one type variable. scheglov 2011/11/01 20:25:59 Done. Show quoted text On 2011/11/01 20:03:03, zundel wrote: > I think the right thing to do is to make this a positive test, given the > clarification by Gilad, and then convert this one to be an example where the > wrong number of argument is a compile-time error, say 'new Foo<param1, param2>' > where Foo is only declared to take one type variable. Done.
6

7 main() {

8 foo = null;

9 }

OLD	NEW