Fix up Curtain mode on MacOS 10.7

Make sure curtain mode doesn't lock up MacOS 10.7

Also adds some extra error logging.

BUG=None
TEST=Go into curtain mode on 10.7 and then disconnect the session.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108184

[dmac, 2011-10-31 22:00:45]

PTAL

[Jamie, 2011-10-31 22:17:46]

LGTM with a couple of minor changes.

http://codereview.chromium.org/8384011/diff/1/remoting/host/capturer_mac.cc
File remoting/host/capturer_mac.cc (right):

http://codereview.chromium.org/8384011/diff/1/remoting/host/capturer_mac.cc#n...
remoting/host/capturer_mac.cc:234: LOG(ERROR) <<
"CGDisplayRemoveReconfigurationCallback " << err;
I'm never convinced by how useful this sort of error handling is. There's
nothing we can do about it if it fails, and logging it doesn't make failures
visible enough to bring them to our attention if our assumptions need to be
challenged. I tend to either ignore the error entirely, or CHECK that the call
succeeds.

That said, it's not something I feel strongly about.

http://codereview.chromium.org/8384011/diff/1/remoting/host/curtain_mac.cc
File remoting/host/curtain_mac.cc (right):

http://codereview.chromium.org/8384011/diff/1/remoting/host/curtain_mac.cc#ne...
remoting/host/curtain_mac.cc:35: // if the current user is on the console.
For consistency, maybe say "if the user is switched in", or "if it is not
already switched out".

http://codereview.chromium.org/8384011/diff/1/remoting/host/curtain_mac.cc#ne...
remoting/host/curtain_mac.cc:42: LOG(ERROR) << "Enabling Curtain mode!";
Remove, or at least lower the log level (and get rid of the exclamation mark!)
If you're going to leave something logged, VLOGging both branches of the if
would seem appropriate.

[commit-bot: I haz the power, 2011-10-31 22:41:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmaclach@chromium.org/8384011/4001

[commit-bot: I haz the power, 2011-10-31 23:45:44]

Try job failure for 8384011-4001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-01 21:06:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmaclach@chromium.org/8384011/4001

[commit-bot: I haz the power, 2011-11-01 22:24:31]

Change committed as 108184