Issue 8384003: Merged Scanner and JavaScriptScanner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8384003: Merged Scanner and JavaScriptScanner. (Closed)

Created:
9 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Merged Scanner and JavaScriptScanner. JavaScriptScanner had become the only concrete subclass of Scanner, so there was no longer a need for the distinction. Also fixed up comments. Committed: http://code.google.com/p/v8/source/detail?r=9854

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -211 lines)			Patch
M	src/parser.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/preparser.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/preparser.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/preparser-api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/scanner.h	View	9 chunks	+112 lines, -133 lines	0 comments	Download
M	src/scanner.cc	View	19 chunks	+33 lines, -60 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	9 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages