Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6824)

Unified Diff: chrome/test/mini_installer_test/chrome_mini_installer.h

Issue 8384002: Add test for Chrome install with existing Chrome Frame Multi-install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/mini_installer_test/chrome_mini_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/mini_installer_test/chrome_mini_installer.h
diff --git a/chrome/test/mini_installer_test/chrome_mini_installer.h b/chrome/test/mini_installer_test/chrome_mini_installer.h
index 550eb41a3d00a91aa03cdd1fa06f95ed2b4078d2..1c4b4a2d9ed456b11c43e6fd56e0237299df4072 100644
--- a/chrome/test/mini_installer_test/chrome_mini_installer.h
+++ b/chrome/test/mini_installer_test/chrome_mini_installer.h
@@ -26,9 +26,9 @@ class ChromeMiniInstaller {
VERSION_FOLDER
};
- // This method returns path to either program files
- // or documents and setting based on the install type.
- bool GetChromeInstallDirectoryLocation(FilePath* path);
+ // Get the location at which Chrome or Chrome Frame is installed.
+ bool GetInstallDirectory(FilePath* path);
+
// Get the base multi-install command.
CommandLine GetBaseMultiInstallCommand();
@@ -122,8 +122,8 @@ class ChromeMiniInstaller {
// Launch IE with |navigate_url|.
void LaunchIE(const std::wstring& navigate_url);
- // Run installer using provided |command|.
- void RunInstaller(const CommandLine& command);
+ // Run the given |command|.
kkania 2011/10/31 17:43:38 I think RunInstaller was a more helpful name. It w
+ void RunCommand(const CommandLine& command);
// Compares the registry key values after overinstall.
bool VerifyOverInstall(const std::string& reg_key_value_before_overinstall,
« no previous file with comments | « no previous file | chrome/test/mini_installer_test/chrome_mini_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698