Add test for Chrome install with existing Chrome Frame Multi-install

chrome/test/mini_installer_test/chrome_mini_installer.h

Index: chrome/test/mini_installer_test/chrome_mini_installer.h
diff --git a/chrome/test/mini_installer_test/chrome_mini_installer.h b/chrome/test/mini_installer_test/chrome_mini_installer.h
index 550eb41a3d00a91aa03cdd1fa06f95ed2b4078d2..06badc0950b9d68854dd836bea6401155699af59 100644
--- a/chrome/test/mini_installer_test/chrome_mini_installer.h
+++ b/chrome/test/mini_installer_test/chrome_mini_installer.h
@@ -27,8 +27,10 @@ class ChromeMiniInstaller {
   };
 
   // This method returns path to either program files
-  // or documents and setting based on the install type.
-  bool GetChromeInstallDirectoryLocation(FilePath* path);
+  // or documents and setting based on the install type
+  // this could be the location of Chrome or Chrome Frame.

[kkania, 2011/10/29 00:10:54]

proper english

[Huyen, 2011/10/29 22:32:33]

good catch, I was a bit lazy in updating the existing comments.

+  bool GetInstallDirectory(FilePath* path);
+
   // Get the base multi-install command.
   CommandLine GetBaseMultiInstallCommand();
 
@@ -124,6 +126,7 @@ class ChromeMiniInstaller {
 
   // Run installer using provided |command|.
   void RunInstaller(const CommandLine& command);
+  void RunInstallerCommand(const CommandLine& command);

[kkania, 2011/10/29 00:10:54]

i have no idea what the difference between these methods is, looking at this api

[Huyen, 2011/10/29 22:32:33]

good catch, I meant to remove RunInstaller(). RunCommand() will replace all
previous RunInstaller() calls. This change will move the responsibility of
checking the type of the install (Chrome/CF) to the caller.

 
   // Compares the registry key values after overinstall.
   bool VerifyOverInstall(const std::string& reg_key_value_before_overinstall,