Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 8384002: Add test for Chrome install with existing Chrome Frame Multi-install (Closed)

Created:
9 years, 1 month ago by Huyen
Modified:
9 years, 1 month ago
Reviewers:
kkania
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add test for Chrome install with existing Chrome Frame user/sys level. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107988

Patch Set 1 : ... #

Total comments: 4

Patch Set 2 : ... #

Total comments: 1

Patch Set 3 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -19 lines) Patch
M chrome/test/mini_installer_test/chrome_mini_installer.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 1 2 8 chunks +26 lines, -14 lines 0 comments Download
M chrome/test/mini_installer_test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/test.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Huyen
9 years, 1 month ago (2011-10-28 22:59:23 UTC) #1
kkania
http://codereview.chromium.org/8384002/diff/5001/chrome/test/mini_installer_test/chrome_mini_installer.h File chrome/test/mini_installer_test/chrome_mini_installer.h (right): http://codereview.chromium.org/8384002/diff/5001/chrome/test/mini_installer_test/chrome_mini_installer.h#newcode31 chrome/test/mini_installer_test/chrome_mini_installer.h:31: // this could be the location of Chrome or ...
9 years, 1 month ago (2011-10-29 00:10:54 UTC) #2
Huyen
thanks! http://codereview.chromium.org/8384002/diff/5001/chrome/test/mini_installer_test/chrome_mini_installer.h File chrome/test/mini_installer_test/chrome_mini_installer.h (right): http://codereview.chromium.org/8384002/diff/5001/chrome/test/mini_installer_test/chrome_mini_installer.h#newcode31 chrome/test/mini_installer_test/chrome_mini_installer.h:31: // this could be the location of Chrome ...
9 years, 1 month ago (2011-10-29 22:32:33 UTC) #3
kkania
9 years, 1 month ago (2011-10-31 17:43:38 UTC) #4
lgtm after fix

http://codereview.chromium.org/8384002/diff/6005/chrome/test/mini_installer_t...
File chrome/test/mini_installer_test/chrome_mini_installer.h (right):

http://codereview.chromium.org/8384002/diff/6005/chrome/test/mini_installer_t...
chrome/test/mini_installer_test/chrome_mini_installer.h:125: // Run the given
|command|.
I think RunInstaller was a more helpful name. It would be nice to include that
it appends system level switch.

Powered by Google App Engine
This is Rietveld 408576698