Improve error handling in the process library.

runtime/bin/file_macos.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <unistd.h>
 #include <libgen.h>
 
@@ skipping 18 matching lines @@
 File::~File() {
   // Close the file (unless it's a standard stream).
   if (handle_->fd() > STDERR_FILENO) {
     Close();
   }
   delete handle_;
 }
 
 
 void File::Close() {
-  assert(handle_->fd() >= 0);
+  ASSERT(handle_->fd() >= 0);
   int err = close(handle_->fd());
   if (err != 0) {
     const int kBufferSize = 1024;
     char error_message[kBufferSize];
     strerror_r(errno, error_message, kBufferSize);
     fprintf(stderr, "%s\n", error_message);
   }
   handle_->set_fd(kClosedFd);
 }
 
 
 bool File::IsClosed() {
   return handle_->fd() == kClosedFd;
 }
 
 
 int64_t File::Read(void* buffer, int64_t num_bytes) {
-  assert(handle_->fd() >= 0);
+  ASSERT(handle_->fd() >= 0);
   return read(handle_->fd(), buffer, num_bytes);
 }
 
 
 int64_t File::Write(const void* buffer, int64_t num_bytes) {
-  assert(handle_->fd() >= 0);
+  ASSERT(handle_->fd() >= 0);
   return write(handle_->fd(), buffer, num_bytes);
 }
 
 
 off_t File::Position() {
-  assert(handle_->fd() >= 0);
+  ASSERT(handle_->fd() >= 0);
   return lseek(handle_->fd(), 0, SEEK_CUR);
 }
 
 
 void File::Flush() {
-  assert(handle_->fd() >= 0);
+  ASSERT(handle_->fd() >= 0);
   fsync(handle_->fd());
 }
 
 
 off_t File::Length() {
-  assert(handle_->fd() >= 0);
+  ASSERT(handle_->fd() >= 0);
   off_t position = lseek(handle_->fd(), 0, SEEK_CUR);
   if (position < 0) {
     // The file is not capable of seeking. Return an error.
     return -1;
   }
   off_t result = lseek(handle_->fd(), 0, SEEK_END);
   lseek(handle_->fd(), position, SEEK_SET);
   return result;
 }
 
@@ skipping 27 matching lines @@
 
 
 const char* File::PathSeparator() {
   return "/";
 }
 
 
 const char* File::StringEscapedPathSeparator() {
   return "/";
 }