chrome/browser/ui/webui/options/personal_options_handler.cc - Issue 8383036: Adding parameter to GetStatusLabels to indicate if links are acceptable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/personal_options_handler.cc

Issue 8383036: Adding parameter to GetStatusLabels to indicate if links are acceptable. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix! Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/personal_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/personal_options_handler.cc b/chrome/browser/ui/webui/options/personal_options_handler.cc

index 0851e4f41f0f443f6e0bfc54f088cfc1edae158d..0d129a23abb8a39e80ea3c876583f2977ea1392a 100644

--- a/chrome/browser/ui/webui/options/personal_options_handler.cc

+++ b/chrome/browser/ui/webui/options/personal_options_handler.cc

@@ -247,7 +247,7 @@ void PersonalOptionsHandler::OnStateChanged() {

bool managed = service->IsManaged();

bool sync_setup_completed = service->HasSyncSetupCompleted();

bool status_has_error = sync_ui_util::GetStatusLabels(

- service, &status_label, &link_label) == sync_ui_util::SYNC_ERROR;

+ service, &status_label, &link_label, true) == sync_ui_util::SYNC_ERROR;

akalin 2011/10/28 19:10:22 what about "true /* has_links */"

jimblackler 2011/11/01 16:15:30 Done.

string16 start_stop_button_label;

bool is_start_stop_button_visible = false;

« chrome/browser/sync/sync_ui_util_unittest.cc ('K') | « chrome/browser/sync/sync_ui_util_unittest.cc ('k') | no next file » | no next file with comments »