Handlify simple functions of [keyed] load stub compiler.

Handlify simple functions of [keyed] load stub compiler.

Handlified functions: CompileLoadNonexistent, CompileLoadField,
CompileLoadConstant, CompileLoadArrayLength, CompileLoadStringLength,
CompileLoadFunctionPrototype.

R=kmillikin@chromium.org 
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9773

[ulan, 2011-10-25 10:03:27]

Please take a look.

[Kevin Millikin (Chromium), 2011-10-25 11:35:49]

LGTM.

http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:530: :
masm->isolate()->builtins()->KeyedLoadIC_Miss();
We usually just indent this with the regular four space indent:

Handle<Code> code = (kind == Code::LOAD_IC)
    ? masm->isolate()->builtins()->LoadIC_Miss()
    : masm->isolate()->builtins()->KeyedLoadIC_Miss();

Otherwise it wastes too much of our 80 columns.

http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:3077: return GetCode(CALLBACKS, name);
It might be a good idea (just to help us keep stuff straight) to rename the raw
pointer version of this function to TryGetCode.

[ulan, 2011-10-25 12:24:53]

Addressed comments, landing.

http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:530: :
masm->isolate()->builtins()->KeyedLoadIC_Miss();
On 2011/10/25 11:35:50, Kevin Millikin wrote:
> We usually just indent this with the regular four space indent:
> 
> Handle<Code> code = (kind == Code::LOAD_IC)
>     ? masm->isolate()->builtins()->LoadIC_Miss()
>     : masm->isolate()->builtins()->KeyedLoadIC_Miss();
> 
> Otherwise it wastes too much of our 80 columns.

Done.

http://codereview.chromium.org/8383033/diff/1/src/arm/stub-cache-arm.cc#newco...
src/arm/stub-cache-arm.cc:3077: return GetCode(CALLBACKS, name);
On 2011/10/25 11:35:50, Kevin Millikin wrote:
> It might be a good idea (just to help us keep stuff straight) to rename the
raw
> pointer version of this function to TryGetCode.

Done.