Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 8383029: Implement external strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address final review comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index ad926893c2e04f8e0646ecd628d8ba749fc41653..c88d5de301674155bc013a6aedf65ce0095c054a 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -399,6 +399,60 @@ UNIT_TEST_CASE(ArrayValues) {
}
+UNIT_TEST_CASE(IsString) {
+ Dart_CreateIsolate(NULL, NULL);
+ Dart_EnterScope(); // Enter a Dart API scope for the unit test.
+
+ uint8_t data8[] = { 'o', 'n', 'e', 0xFF };
+
+ Dart_Handle str8 = Dart_NewString8(data8, ARRAY_SIZE(data8));
+ EXPECT_VALID(str8);
+ EXPECT(Dart_IsString(str8));
+ EXPECT(Dart_IsString8(str8));
+ EXPECT(Dart_IsString16(str8));
+
+ Dart_Handle ext8 = Dart_NewExternalString8(data8, ARRAY_SIZE(data8),
+ NULL, NULL);
+ EXPECT_VALID(ext8);
+ EXPECT(Dart_IsString(ext8));
+ EXPECT(Dart_IsString8(ext8));
+ EXPECT(Dart_IsString16(ext8));
+
+ uint16_t data16[] = { 't', 'w', 'o', 0xFFFF };
+
+ Dart_Handle str16 = Dart_NewString16(data16, ARRAY_SIZE(data16));
+ EXPECT_VALID(str16);
+ EXPECT(Dart_IsString(str16));
+ EXPECT(!Dart_IsString8(str16));
+ EXPECT(Dart_IsString16(str16));
+
+ Dart_Handle ext16 = Dart_NewExternalString16(data16, ARRAY_SIZE(data16),
+ NULL, NULL);
+ EXPECT_VALID(ext16);
+ EXPECT(Dart_IsString(ext16));
+ EXPECT(!Dart_IsString8(ext16));
+ EXPECT(Dart_IsString16(ext16));
+
+ uint32_t data32[] = { 'f', 'o', 'u', 'r', 0x10FFFF };
+
+ Dart_Handle str32 = Dart_NewString32(data32, ARRAY_SIZE(data32));
+ EXPECT_VALID(str32);
+ EXPECT(Dart_IsString(str32));
+ EXPECT(!Dart_IsString8(str32));
+ EXPECT(!Dart_IsString16(str32));
+
+ Dart_Handle ext32 = Dart_NewExternalString32(data32, ARRAY_SIZE(data32),
+ NULL, NULL);
+ EXPECT_VALID(ext32);
+ EXPECT(Dart_IsString(ext32));
+ EXPECT(!Dart_IsString8(ext32));
+ EXPECT(!Dart_IsString16(ext32));
+
+ Dart_ExitScope(); // Exit the Dart API scope.
+ Dart_ShutdownIsolate();
+}
+
+
#if defined(TARGET_ARCH_IA32) // only ia32 can run execution tests.
UNIT_TEST_CASE(ListAccess) {
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698