Implement external strings.

runtime/vm/object_store.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object_store.h"
 
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/raw_object.h"
 #include "vm/visitor.h"
 
 namespace dart {
 
 ObjectStore::ObjectStore()
   : object_class_(Class::null()),
     function_interface_(Type::null()),
     number_interface_(Type::null()),
     int_interface_(Type::null()),
     smi_class_(Class::null()),
     mint_class_(Class::null()),
     bigint_class_(Class::null()),
     double_interface_(Type::null()),
     double_class_(Class::null()),
     string_interface_(Type::null()),
     one_byte_string_class_(Class::null()),
     two_byte_string_class_(Class::null()),
     four_byte_string_class_(Class::null()),

[Ivan Posva, 2011/11/18 19:36:44]

New fields are not being initialized.

[cshapiro, 2011/11/19 01:08:29]

Done.  I also added an initialization for the new byte buffer class.

     bool_interface_(Type::null()),
     bool_class_(Class::null()),
     list_interface_(Type::null()),
     array_class_(Class::null()),
     immutable_array_class_(Class::null()),
     unhandled_exception_class_(Class::null()),
     stacktrace_class_(Class::null()),
     jsregexp_class_(Class::null()),
     true_value_(Bool::null()),
     false_value_(Bool::null()),
@@ skipping 29 matching lines @@
 RawClass* ObjectStore::GetClass(int index) {
   switch (index) {
     case kObjectClass: return object_class_;
     case kSmiClass: return smi_class_;
     case kMintClass: return mint_class_;
     case kBigintClass: return bigint_class_;
     case kDoubleClass: return double_class_;
     case kOneByteStringClass: return one_byte_string_class_;
     case kTwoByteStringClass: return two_byte_string_class_;
     case kFourByteStringClass: return four_byte_string_class_;
+    case kExternalOneByteStringClass: return external_one_byte_string_class_;
+    case kExternalTwoByteStringClass: return external_two_byte_string_class_;
+    case kExternalFourByteStringClass: return external_four_byte_string_class_;
     case kBoolClass: return bool_class_;
     case kArrayClass: return array_class_;
     case kImmutableArrayClass: return immutable_array_class_;
     case kUnhandledExceptionClass: return unhandled_exception_class_;
     case kStacktraceClass: return stacktrace_class_;
     case kJSRegExpClass: return jsregexp_class_;
     default: break;
   }
   UNREACHABLE();
   return Class::null();
@@ skipping 11 matching lines @@
   } else if (raw_class == bigint_class_) {
     return kBigintClass;
   } else if (raw_class == double_class_) {
     return kDoubleClass;
   } else if (raw_class == one_byte_string_class_) {
     return kOneByteStringClass;
   } else if (raw_class == two_byte_string_class_) {
     return kTwoByteStringClass;
   } else if (raw_class == four_byte_string_class_) {
     return kFourByteStringClass;
+  } else if (raw_class == external_one_byte_string_class_) {
+    return kExternalOneByteStringClass;
+  } else if (raw_class == external_two_byte_string_class_) {
+    return kExternalTwoByteStringClass;
+  } else if (raw_class == external_four_byte_string_class_) {
+    return kExternalFourByteStringClass;
   } else if (raw_class == bool_class_) {
     return kBoolClass;
   } else if (raw_class == array_class_) {
     return kArrayClass;
   } else if (raw_class == immutable_array_class_) {
     return kImmutableArrayClass;
   } else if (raw_class == unhandled_exception_class_) {
     return kUnhandledExceptionClass;
   } else if (raw_class == stacktrace_class_) {
     return kStacktraceClass;
@@ skipping 46 matching lines @@
     return kBoolInterface;
   } else if (raw_type == string_interface()) {
     return kStringInterface;
   } else if (raw_type == list_interface()) {
     return kListInterface;
   }
   return kInvalidIndex;
 }
 
 }  // namespace dart