chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm - Issue 8383026: [Mac] Don't crash when dragging and dropping bookmarks within a bookmarks folder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

Issue 8383026: [Mac] Don't crash when dragging and dropping bookmarks within a bookmarks folder. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

index 8a52dd2ccc02ae1bf863f3b3802d6f7b6d90fe5c..7eb20aae5cdc17198a4b6b71ee7c975a93db4855 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

@@ -596,6 +596,13 @@ TEST_F(BookmarkBarFolderControllerTest, MenuPlacementWhileScrollingDeleting) {

EXPECT_CGFLOAT_EQ(oldTop - bookmarks::kScrollWindowVerticalMargin, newTop);

}

+// Make sure that we return the correct browser window.

+TEST_F(BookmarkBarFolderControllerTest, BrowserWindow) {

+ scoped_nsobject<BookmarkBarFolderController> controller;

+ controller.reset(SimpleBookmarkBarFolderController());

Robert Sesek 2011/10/25 14:51:05 Merge this line with the previous?

Ilya Sherman 2011/10/25 19:20:54 Done. (Was copy/pasted.)

+ EXPECT_EQ([bar_ browserWindow], [controller browserWindow]);

@interface FakedDragInfo : NSObject {

@public

NSPoint dropLocation_;