Issue 8383026: [Mac] Don't crash when dragging and dropping bookmarks within a bookmarks folder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8383026: [Mac] Don't crash when dragging and dropping bookmarks within a bookmarks folder. (Closed)

Created:
9 years, 2 months ago by Ilya Sherman

Modified:
9 years, 2 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

[Mac] Don't crash when dragging and dropping bookmarks within a bookmarks folder. BUG=101184 TEST=drag&drop bookmarks within a folder, no crash (also unit tested) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107175

Patch Set 1 #

Total comments: 2

Patch Set 2 : De-nitting #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

lgtm http://codereview.chromium.org/8383026/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm (right): http://codereview.chromium.org/8383026/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm#newcode602 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm:602: controller.reset(SimpleBookmarkBarFolderController()); Merge this line with the previous?

9 years, 2 months ago (2011-10-25 14:51:05 UTC) #2

Ilya Sherman

9 years, 2 months ago (2011-10-25 19:20:54 UTC) #3

http://codereview.chromium.org/8383026/diff/1/chrome/browser/ui/cocoa/bookmar...
File
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
(right):

http://codereview.chromium.org/8383026/diff/1/chrome/browser/ui/cocoa/bookmar...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm:602:
controller.reset(SimpleBookmarkBarFolderController());
On 2011/10/25 14:51:05, rsesek wrote:
> Merge this line with the previous?

Done.  (Was copy/pasted.)

Expand Messages | Collapse Messages