Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 8383022: [Aura] Turns on Window opacity support. (Closed)

Created:
9 years, 2 months ago by xiyuan
Modified:
9 years, 2 months ago
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

[Aura] Turns on Window opacity support. BUG=98308 TEST=None. Wait until app list window is checked in to verify. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107138

Patch Set 1 #

Total comments: 2

Patch Set 2 : simplify per sky's comments in #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M views/widget/native_widget_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
Thinking of using this for show/hide animation of app list window instead of using css ...
9 years, 2 months ago (2011-10-24 23:56:01 UTC) #1
sky
http://codereview.chromium.org/8383022/diff/1/views/widget/native_widget_aura.cc File views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8383022/diff/1/views/widget/native_widget_aura.cc#newcode399 views/widget/native_widget_aura.cc:399: window_->SetOpacity(opacity); I think we should just call through to ...
9 years, 2 months ago (2011-10-24 23:59:50 UTC) #2
xiyuan
http://codereview.chromium.org/8383022/diff/1/views/widget/native_widget_aura.cc File views/widget/native_widget_aura.cc (right): http://codereview.chromium.org/8383022/diff/1/views/widget/native_widget_aura.cc#newcode399 views/widget/native_widget_aura.cc:399: window_->SetOpacity(opacity); On 2011/10/24 23:59:51, sky wrote: > I think ...
9 years, 2 months ago (2011-10-25 04:19:09 UTC) #3
sky
LGTM
9 years, 2 months ago (2011-10-25 14:49:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/8383022/5
9 years, 2 months ago (2011-10-25 15:38:54 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 16:53:49 UTC) #6
Change committed as 107138

Powered by Google App Engine
This is Rietveld 408576698