Issue 8383020: Upstream: Android Test scripts (phase 3)

Issue 8383020: Upstream: Android Test scripts (phase 3) (Closed)

Created:
9 years, 2 months ago by michaelbai

Modified:
9 years, 2 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, stuartmorgan+watch_chromium.org, Alexander Potapenko, Timur Iskhodzhanov

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Upstream: Android Test scripts (phase 3) BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107189

Patch Set 2 : Address comments #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -3 lines)			Patch
A	build/android/perf_tests_helper.py	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download
M	build/android/test_package.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download
A	build/android/valgrind_tools.py	View	1	1 chunk	+186 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/8383020/diff/1/build/android/perf_tests_helper.py File build/android/perf_tests_helper.py (right): http://codereview.chromium.org/8383020/diff/1/build/android/perf_tests_helper.py#newcode9 build/android/perf_tests_helper.py:9: nit: need another blank line here http://codereview.chromium.org/8383020/diff/1/build/android/perf_tests_helper.py#newcode35 build/android/perf_tests_helper.py:35: important_marker ...

9 years, 2 months ago (2011-10-25 01:12:37 UTC) #2

michaelbai

http://codereview.chromium.org/8383020/diff/1/build/android/perf_tests_helper.py File build/android/perf_tests_helper.py (right): http://codereview.chromium.org/8383020/diff/1/build/android/perf_tests_helper.py#newcode9 build/android/perf_tests_helper.py:9: On 2011/10/25 01:12:37, Nirnimesh wrote: > nit: need another ...

9 years, 2 months ago (2011-10-25 16:23:58 UTC) #3

LGTM

Expand Messages | Collapse Messages