Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 8383018: Init selection_text_offset_ in class constructor. (Closed)

Created:
9 years, 2 months ago by Peng
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Alexander Potapenko, jam, Timur Iskhodzhanov, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, bryeung, varunjain
Visibility:
Public.

Description

Init selection_text_offset_ in class constructor. BUG=101342 TEST=git try --bot=linux_valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Peng
9 years, 2 months ago (2011-10-24 22:29:08 UTC) #1
oshima
LGTM
9 years, 2 months ago (2011-10-24 22:51:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/8383018/1
9 years, 2 months ago (2011-10-25 00:20:25 UTC) #3
commit-bot: I haz the power
Presubmit check for 8383018-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 2 months ago (2011-10-25 00:20:30 UTC) #4
Peng
Hi John, Could you please review this CL? Thanks.
9 years, 2 months ago (2011-10-25 00:22:45 UTC) #5
jam
lgtm
9 years, 2 months ago (2011-10-25 05:40:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/8383018/1
9 years, 2 months ago (2011-10-25 13:17:13 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 14:36:57 UTC) #8
Change committed as 107114

Powered by Google App Engine
This is Rietveld 408576698