Add a command-line switch --skip-gpu-data-loading.

chrome/test/ui/ui_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/ui/ui_test.h"
 
 #if defined(OS_POSIX)
 #include <signal.h>
 #include <sys/types.h>
 #endif
@@ skipping 185 matching lines @@
 void UITestBase::SetLaunchSwitches() {
   // We need cookies on file:// for things like the page cycler.
   if (enable_file_cookies_)
     launch_arguments_.AppendSwitch(switches::kEnableFileCookies);
   if (dom_automation_enabled_)
     launch_arguments_.AppendSwitch(switches::kDomAutomationController);
   if (!homepage_.empty())
     launch_arguments_.AppendSwitchASCII(switches::kHomePage, homepage_);
   if (!test_name_.empty())
     launch_arguments_.AppendSwitchASCII(switches::kTestName, test_name_);
+  launch_arguments_.AppendSwitch(switches::kSkipGpuDataLoading);

[Paweł Hajdan Jr., 2011/10/25 08:46:40]

With the change in test_launcher_utils this shouldn't be needed. If it is, it's
a bug, and you should make sure we call test_launcher_utils at the right place.

It's just not maintainable to duplicate this code.

[Zhenyao Mo, 2011/10/25 15:51:12]

I double-checked again, and
test_launcher_utils::PrepareBrowserCommandLineForTests are not called directly
or indirectly by ui_test at all.

If it is a bug, I need points where in the ui_test we should call the
test_launcher_utils::PrepareBrowserCommandLineForTests.  Apparently the current
ui tests run fine without calling it, that's the part I don't understand.

[Paweł Hajdan Jr., 2011/10/25 16:04:36]

I think it's called by ProxyLauncher:
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/test/automatio...

 }
 
 void UITestBase::SetUpProfile() {
 }
 
 void UITestBase::LaunchBrowser() {
   LaunchBrowser(launch_arguments_, clear_profile_);
 }
 
 void UITestBase::LaunchBrowserAndServer() {
@@ skipping 578 matching lines @@
     base::PlatformThread::Sleep(TestTimeouts::action_timeout_ms() / kCycles);
   }
 
   LOG(INFO) << "Elapsed time: " << (base::Time::Now() - start).InSecondsF()
             << " seconds"
             << " call failed " << fail_count << " times"
             << " state was incorrect " << incorrect_state_count << " times";
   ADD_FAILURE() << "Timeout reached in " << __FUNCTION__;
   return false;
 }