Issue 8383002: Handle COW-arrays correctly when converting smi->double fast elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8383002: Handle COW-arrays correctly when converting smi->double fast elements. (Closed)

Created:
9 years, 2 months ago by Yang

Modified:
9 years, 2 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Handle COW-arrays correctly when converting smi->double fast elements. TEST=mjsunit/elements-transition.js Committed: http://code.google.com/p/v8/source/detail?r=9759

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -28 lines)			Patch
M	src/x64/code-stubs-x64.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	7 chunks	+61 lines, -26 lines	1 comment	Download
M	test/mjsunit/elements-transition.js	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

This fixes the COW-related bug Jakob mentioned in his mail. The test case includes the ...

9 years, 2 months ago (2011-10-24 14:23:51 UTC) #1

danno

9 years, 2 months ago (2011-10-24 15:01:47 UTC) #2

lgtm

LGTM with nits

http://codereview.chromium.org/8383002/diff/1/src/x64/codegen-x64.cc
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/8383002/diff/1/src/x64/codegen-x64.cc#newcode216
src/x64/codegen-x64.cc:216: // length does not have to be set since we still use
the exact same field
Or even simpler:
NaNs.  The Array's length remains unchanged.

Expand Messages | Collapse Messages