Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 8383001: Add ENABLE_JAVA_BRIDGE (Closed)

Created:
9 years, 2 months ago by Steve Block
Modified:
9 years, 2 months ago
Reviewers:
tonyg, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Add ENABLE_JAVA_BRIDGE This flag allows us to avoid compiling and executing JavaBridge code when the feature is not required. The flag defaults to off, but is enabled on Android. BUG=96703 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107010

Patch Set 1 #

Total comments: 4

Patch Set 2 : Minimize use of ENABLE guard #

Patch Set 3 : Use 'sources!' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M build/common.gypi View 3 chunks +5 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +14 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Steve Block
See http://codereview.chromium.org/8366034 for context
9 years, 2 months ago (2011-10-24 12:57:48 UTC) #1
Steve Block
9 years, 2 months ago (2011-10-24 14:29:40 UTC) #2
jam
http://codereview.chromium.org/8383001/diff/1/content/content_browser.gypi File content/content_browser.gypi (right): http://codereview.chromium.org/8383001/diff/1/content/content_browser.gypi#newcode725 content/content_browser.gypi:725: 'browser/renderer_host/java_bridge_channel_host.cc', the convention is to list all the file ...
9 years, 2 months ago (2011-10-24 17:43:21 UTC) #3
Steve Block
9 years, 2 months ago (2011-10-24 18:07:04 UTC) #4
Steve Block
Checked with bradnelson, and 'sources!' is preferred to 'exclude' in this case.
9 years, 2 months ago (2011-10-24 22:55:33 UTC) #5
jam
9 years, 2 months ago (2011-10-24 22:59:09 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698