gclient.py - Issue 8382030: depot_tools: Add git svn find-rev for safesync_url parsing (commonly LKGR link).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 8382030: depot_tools: Add git svn find-rev for safesync_url parsing (commonly LKGR link). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient.py

===================================================================

--- gclient.py (revision 107077)

+++ gclient.py (working copy)

@@ -923,6 +923,13 @@

handle = urllib.urlopen(s.safesync_url)

rev = handle.read().strip()

handle.close()

+ if gclient_scm.GetScmName(s.url) == 'git':

+ scm = gclient_scm.GitWrapper(s.url, s.root.root_dir, s.name)

+ svn_rev = scm.Sha1FromSvnRevision(rev)

M-A Ruel 2011/10/25 13:11:14 What happens when upstream is git and not git-svn?

+ if len(svn_rev):

+ rev = svn_rev

+ else:

+ print '\nWARNING: No git sha1 for revision %s found.' % rev

if len(rev):

self._options.revisions.append('%s@%s' % (s.name, rev))

if not self._options.revisions:

« no previous file with comments | « no previous file | gclient_scm.py » ('j') | gclient_scm.py » ('J')