Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8382021: Move resource_codes to content/public/common. (Closed)

Created:
9 years, 2 months ago by jam
Modified:
9 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina, yoshiki+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, mihaip+watch_chromium.org, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move resource_codes to content/public/common. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107061

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -84 lines) Patch
M chrome/app/chrome_exe_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_import_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/hang_monitor/hung_window_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/web_cache_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/hung_renderer_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_result_codes.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/service_child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_process_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/database_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_host_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_main_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/handle_enumerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/process_watcher_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
D content/common/result_codes.h View 1 chunk +0 lines, -42 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/common/result_codes.h View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 2 months ago (2011-10-24 23:47:17 UTC) #1
Dirk Pranke
lgtm. http://codereview.chromium.org/8382021/diff/1/chrome/browser/renderer_host/render_widget_host_view_views.cc File chrome/browser/renderer_host/render_widget_host_view_views.cc (right): http://codereview.chromium.org/8382021/diff/1/chrome/browser/renderer_host/render_widget_host_view_views.cc#newcode24 chrome/browser/renderer_host/render_widget_host_view_views.cc:24: #include "content/common/view_messages.h" Nit: Please move this line before ...
9 years, 2 months ago (2011-10-24 23:53:48 UTC) #2
jam
9 years, 2 months ago (2011-10-24 23:55:32 UTC) #3 
http://codereview.chromium.org/8382021/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/8382021/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:24: #include
"content/common/view_messages.h"
On 2011/10/24 23:53:48, Dirk Pranke wrote:
> Nit: Please move this line before line 23 (alphabetizing, even though this
isn't
> part of your edit).

Done.

Powered by Google App Engine
This is Rietveld 408576698