Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/extensions/app_notification_manager_sync_unittest.cc

Issue 8382010: Some fixups for app notifications: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_notification_manager_sync_unittest.cc
===================================================================
--- chrome/browser/extensions/app_notification_manager_sync_unittest.cc (revision 106989)
+++ chrome/browser/extensions/app_notification_manager_sync_unittest.cc (working copy)
@@ -146,12 +146,6 @@
return notif;
}
- static AppNotification* CreateNotification(const AppNotification& notif) {
- return CreateNotification(
- notif.is_local(), notif.guid(), notif.extension_id(), notif.title(),
- notif.body(), notif.link_url().spec(), notif.link_text());
- }
-
static SyncData CreateSyncData(int suffix) {
scoped_ptr<AppNotification> notif(CreateNotification(suffix));
return AppNotificationManager::CreateSyncDataFromNotification(*notif);
@@ -491,9 +485,8 @@
SyncChangeList changes;
changes.push_back(CreateSyncChange(
SyncChange::ACTION_ADD, CreateNotification(3)));
+ changes.push_back(CreateSyncChange(SyncChange::ACTION_DELETE, n1->Copy()));
changes.push_back(CreateSyncChange(
- SyncChange::ACTION_DELETE, CreateNotification(*n1)));
- changes.push_back(CreateSyncChange(
SyncChange::ACTION_ADD, CreateNotification(4)));
model()->ProcessSyncChanges(FROM_HERE, changes);
« no previous file with comments | « chrome/browser/extensions/app_notification_manager.cc ('k') | chrome/browser/extensions/extension_app_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698