Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 8382002: Suppress the leaks from webkit::npapi::WebPluginImpl::HandleURLRequestInternal (issue 101345) (Closed)

Created:
9 years, 2 months ago by Alexander Potapenko
Modified:
9 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Suppress the leaks from webkit::npapi::WebPluginImpl::HandleURLRequestInternal (issue 101345) Suppress the leak in OutOfProcessPPAPITest.Graphics2D (issue 101347) TBR=oshima BUG=101345, 101347 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Potapenko
TBR
9 years, 2 months ago (2011-10-24 12:08:01 UTC) #1
oshima
9 years, 2 months ago (2011-10-24 16:22:51 UTC) #2
LGTM

On Mon, Oct 24, 2011 at 5:08 AM, <glider@chromium.org> wrote:

> Reviewers: oshima,
>
> Message:
> TBR
>
> Description:
> Suppress the leaks from webkit::npapi::WebPluginImpl::**
> HandleURLRequestInternal
> (issue 101345)
> Suppress the leak in OutOfProcessPPAPITest.**Graphics2D (issue 101347)
>
> TBR=oshima
> BUG=101345,101347
> Committed: http://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=106906<http://src.chromium.org/viewvc/chrome?view=rev&revision=106906>
>
> Please review this at
http://codereview.chromium.**org/8382002/<http://codereview.chromium.org/8382...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     tools/valgrind/memcheck/**suppressions.txt
>
>
> Index: tools/valgrind/memcheck/**suppressions.txt
> ==============================**==============================**=======
> --- tools/valgrind/memcheck/**suppressions.txt    (revision 106905)
> +++ tools/valgrind/memcheck/**suppressions.txt    (working copy)
> @@ -4978,8 +4978,24 @@
>    fun:_**ZN7WebCore12EventHandler21hand**leMousePressEventERKNS_**
> 28MouseEventWithHitTestResults**E
>    fun:_**ZN7WebCore12EventHandler21hand**leMousePressEventERKNS_**
> 18PlatformMouseEventE
>  }
> +{
> +   bug_101345
> +   Memcheck:Leak
> +   fun:_Znw*
> +   fun:_**ZN22WebPluginDelegateProxy20Cr**eateResourceClientEmRK4GURLi
> +   fun:_**ZN6webkit5npapi13WebPluginImpl**24HandleURLRequestInternalEPKc*
> *S3_S3_S3_jibNS1_8ReferrerEbb
> +}
> +{
> +   bug_101347
> +   Memcheck:Leak
> +   fun:_Znw*
> +   fun:_**ZN2pp25CompletionCallbackFacto**ryIN5ppapi5proxy20PPB_**
> Graphics2D_ProxyENS2_**26ProxyNonThreadSafeRefCountEE**
> 17NewCallbackHelperINS5_**11Dispatcher1IMS3_FviRKNS1_**
> 12HostResourceEES8_EEEENS_**18CompletionCallbackERKT_
> +   fun:_**ZN2pp25CompletionCallbackFacto**ryIN5ppapi5proxy20PPB_**
> Graphics2D_ProxyENS2_**26ProxyNonThreadSafeRefCountEE**
> 11NewCallbackIMS3_FviRKNS1_**12HostResourceEES7_EENS_**
> 18CompletionCallbackET_RKT0_
> +   fun:_**ZN2pp25CompletionCallbackFacto**ryIN5ppapi5proxy20PPB_**
> Graphics2D_ProxyENS2_**26ProxyNonThreadSafeRefCountEE**
> 19NewOptionalCallbackIMS3_**FviRKNS1_12HostResourceEES7_**
> EENS_18CompletionCallbackET_**RKT0_
> +   fun:_**ZN5ppapi5proxy38EnterHostFromH**ostResourceForceCallbackINS_**
> 5thunk18PPB_Graphics2D_**APIEEC1IN2pp25CompletionCallba**
> ckFactoryINS0_20PPB_**Graphics2D_ProxyENS0_**
> 26ProxyNonThreadSafeRefCountEE**EMS8_FviRKNS_**
> 12HostResourceEESB_EESD_RT_T0_**RKT1_
> +   fun:_ZN5ppapi5proxy20PPB_**Graphics2D_**Proxy10OnMsgFlushERKNS_**
> 12HostResourceE
> +}
>
> -
>  #-----------------------------**------------------------------**
> ------------
>  # 4. These only occur on our Google workstations
>  {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698