Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: build/common.gypi

Issue 8382001: OpenBSD patches for base and build, part 2 (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fixes for prev. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/sys_info_linux.cc ('K') | « base/sys_info_openbsd.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index cc29fc1d4562ed7f0e7944cc5d0dd29b8c32cbb2..50ab7e1193232a6505ed0f9434508278e992c27a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1153,9 +1153,11 @@
'-Wextra',
'-Werror',
],
- 'cflags': [
+ 'cflags_cc': [
# Don't warn about hash_map in third-party code.
'-Wno-deprecated',
+ ],
+ 'cflags': [
# Don't warn about printf format problems.
# This is off by default in gcc but on in Ubuntu's gcc(!).
'-Wno-format',
@@ -1246,7 +1248,10 @@
['exclude', '(^|/)(wayland)_[^/]*\\.(h|cc)$'],
],
}],
- ['OS!="linux"', {
+ # Do not exclude the linux files on OpenBSD since most of them can be
Mark Mentovai 2011/10/24 18:51:55 “most of them are shared at this point” because “c
Robert Nagy 2011/10/24 19:30:20 Done.
+ # and has to be shared at this point.
+ # In case a file is not needed, it is going to be excluded laster on.
Mark Mentovai 2011/10/24 18:51:55 Spelling: laster->later
Robert Nagy 2011/10/24 19:30:20 Done.
+ ['OS!="linux" and OS!="openbsd"', {
'sources/': [
['exclude', '_linux(_unittest)?\\.(h|cc)$'],
['exclude', '(^|/)linux/'],
« base/sys_info_linux.cc ('K') | « base/sys_info_openbsd.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698