Merge 98105 - Web Inspector: Advanced search is working very slowly and does not show searching p...

Source/WebCore/inspector/front-end/ScriptsSearchScope.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 16 matching lines @@
  */
 
 /**
  * @constructor
  * @implements {WebInspector.SearchScope}
  */
 WebInspector.ScriptsSearchScope = function()
 {
     // FIXME: Add title once it is used by search controller.
     WebInspector.SearchScope.call(this)
+    this._searchId = 0;
 }
 
 WebInspector.ScriptsSearchScope.prototype = {
     /**
      * @param {WebInspector.SearchConfig} searchConfig
      * @param {function(Object)} searchResultCallback
-     * @param {function()} searchFinishedCallback
+     * @param {function(boolean)} searchFinishedCallback
      */
     performSearch: function(searchConfig, searchResultCallback, searchFinishedCallback)
     {
-        var callbacksLeft = 0;
-
-        function maybeSearchFinished()
+        this.stopSearch();
+        
+        var uiSourceCodes = this._sortedUISourceCodes();
+        var uiSourceCodeIndex = 0;
+        
+        function filterOutContentScripts(uiSourceCode)
         {
-            if (callbacksLeft === 0)
-                searchFinishedCallback();                
+            return !uiSourceCode.isContentScript;
         }
         
-        function searchCallbackWrapper(uiSourceCode, searchMatches)
+        // FIXME: Add setting to search in content scripts as well.
+        uiSourceCodes.filter(filterOutContentScripts);
+
+        function continueSearch()
         {
-            if (searchMatches.length) {
-                var searchResult = new WebInspector.FileBasedSearchResultsPane.SearchResult(uiSourceCode, searchMatches);
-                searchResultCallback(searchResult);
+            // FIXME: Enable support for counting matches for incremental search.
+            // FIXME: Enable support for bounding search results/matches number to keep inspector responsive.
+            if (uiSourceCodeIndex < uiSourceCodes.length) {
+                var uiSourceCode = uiSourceCodes[uiSourceCodeIndex++];
+                uiSourceCode.searchInContent(searchConfig.query, !searchConfig.ignoreCase, searchConfig.isRegex, searchCallbackWrapper.bind(this, this._searchId, uiSourceCode));
+            } else 
+                searchFinishedCallback(true);
+        }
+
+        function searchCallbackWrapper(searchId, uiSourceCode, searchMatches)
+        {
+            if (searchId !== this._searchId) {
+                searchFinishedCallback(false);
+                return;
             }
-            --callbacksLeft;
-            maybeSearchFinished();
+                
+            var searchResult = new WebInspector.FileBasedSearchResultsPane.SearchResult(uiSourceCode, searchMatches);
+            searchResultCallback(searchResult);
+            continueSearch.call(this);
         }
         
-        var uiSourceCodes = this._sortedUISourceCodes();
-        // FIXME: Enable support for counting matches for incremental search.
-        // FIXME: Enable support for bounding search results/matches number to keep inspector responsive.
-        for (var i = 0; i < uiSourceCodes.length; i++) {
-            var uiSourceCode = uiSourceCodes[i];
-            // FIXME: Add setting to search in content scripts as well.
-            if (!uiSourceCode.isContentScript) {
-                // Increase callbacksLeft first because searchInContent call could be synchronous.
-                callbacksLeft++;
-                // FIXME: We should not request next searchInContent unless previous one is already finished.  
-                uiSourceCode.searchInContent(searchConfig.query, !searchConfig.ignoreCase, searchConfig.isRegex, searchCallbackWrapper.bind(this, uiSourceCode));
-            }
-        }
-        maybeSearchFinished();
+        continueSearch.call(this);
+        return uiSourceCodes.length;
     },
 
     stopSearch: function()
     {
-        // FIXME: Implement search so that it could be stopped.
+        ++this._searchId;
     },
 
     /**
      * @param {WebInspector.SearchConfig} searchConfig
      */
     createSearchResultsPane: function(searchConfig)
     {
         return new WebInspector.ScriptsSearchResultsPane(searchConfig);
     },
 
@@ skipping 78 matching lines @@
      * @param {WebInspector.RawSourceCode} rawSourceCode
      * @param {Element} anchor
      */
     formatRawSourceCodeAnchor: function(rawSourceCode, anchor)
     {
         // Empty because we don't want to ever update anchor contents after creation.
     }
 }
 
 WebInspector.ScriptsSearchResultsPane.LinkifierFormatter.prototype.__proto__ = WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype;