src/objects.cc - Issue 8381040: Move some heap verification code in under the --verify-heap flag to speed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 8381040: Move some heap verification code in under the --verify-heap flag to speed (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

===================================================================

--- src/objects.cc (revision 9765)

+++ src/objects.cc (working copy)

@@ -3231,7 +3231,9 @@

if (result->IsMap() &&

Map::cast(result)->EquivalentToForNormalization(fast, mode)) {

#ifdef DEBUG

- Map::cast(result)->SharedMapVerify();

+ if (FLAG_verify_heap) {

+ Map::cast(result)->SharedMapVerify();

+ }

if (FLAG_enable_slow_asserts) {

// The cached map should match newly created normalized map bit-by-bit.

Object* fresh;

@@ -4727,7 +4729,7 @@

Map::cast(result)->set_is_shared(sharing == SHARED_NORMALIZED_MAP);

#ifdef DEBUG

- if (Map::cast(result)->is_shared()) {

+ if (FLAG_verify_heap && Map::cast(result)->is_shared()) {

Map::cast(result)->SharedMapVerify();

}

#endif

« no previous file with comments | « src/incremental-marking.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »