Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 8381034: Change the dev toggle in Extensions options page to use text-align instead of float so it mirrors... (Closed)

Created:
9 years, 2 months ago by Yair (progame)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), mihaip+watch_chromium.org
Visibility:
Public.

Description

Change the dev toggle in Extensions options page to use text-align instead of float so it mirrors properly in RTL UI. BUG=101461 TEST=Open chrome://extensions/. Notice the dev toggle is to the right for English UI and to the left for Hebrew UI. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107116

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/extension_settings.css View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Finnur
Your change description needs a TEST= line. http://codereview.chromium.org/8381034/diff/1/AUTHORS File AUTHORS (right): http://codereview.chromium.org/8381034/diff/1/AUTHORS#newcode143 AUTHORS:143: Yair Yogev ...
9 years, 2 months ago (2011-10-25 10:43:21 UTC) #1
Yair (progame)
Thanks for the quick review! On 2011/10/25 10:43:21, Finnur wrote: > Your change description needs ...
9 years, 2 months ago (2011-10-25 11:13:41 UTC) #2
Finnur
> When i removed the float it removed a lot of vertical margins. I see. ...
9 years, 2 months ago (2011-10-25 12:35:33 UTC) #3
Yair (progame)
great :) Jeremy: can you approve this RTLwise? i think i also need a hand ...
9 years, 2 months ago (2011-10-25 13:56:25 UTC) #4
jeremy
From an RTL perspective LGTM
9 years, 2 months ago (2011-10-25 13:58:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/progame@chromium.org/8381034/4001
9 years, 2 months ago (2011-10-25 13:59:29 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 15:09:59 UTC) #7
Change committed as 107116

Powered by Google App Engine
This is Rietveld 408576698