Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 8381024: more content exports. (Closed)

Created:
9 years, 2 months ago by Dirk Pranke
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : yet more exports, and a couple of dependency fixes #

Patch Set 3 : don't link installer_unittests, setup against content #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M content/browser/download/download_buffer.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/url_request_slow_download_job.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notification_service_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/worker_host/worker_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/worker_messages.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/notification_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/page_transition_types.h View 1 chunk +8 lines, -6 lines 0 comments Download
M ipc/ipc_message_macros.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
9 years, 2 months ago (2011-10-24 22:17:26 UTC) #1
jam
lgtm
9 years, 2 months ago (2011-10-25 00:11:22 UTC) #2
Dirk Pranke
Will, can I get an approval for the change in content/browser/net? Thanks.
9 years, 1 month ago (2011-10-27 01:12:28 UTC) #3
Dirk Pranke
On 2011/10/27 01:12:28, Dirk Pranke wrote: > Will, can I get an approval for the ...
9 years, 1 month ago (2011-10-27 01:17:28 UTC) #4
jar (doing other things)
9 years, 1 month ago (2011-10-27 01:35:05 UTC) #5
LGTM for the url_request_slow_download_job.h addition

Powered by Google App Engine
This is Rietveld 408576698