Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 8381022: check the return value of base::SysInfo::MaxSharedMemorySize(). (Closed)

Created:
9 years, 1 month ago by Robert Nagy
Modified:
9 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add a unittest for base::SysInfo::MaxSharedMemorySize on all OS_POSIX systems where it's available by checking the return value. BUG= TEST=base_unittests SysInfoTest.MaxSharedMemorySize Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107014

Patch Set 1 #

Patch Set 2 : fix signedness error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/sys_info_unittest.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Robert Nagy
9 years, 1 month ago (2011-10-24 21:23:01 UTC) #1
Mark Mentovai
LGTM. I fixed your TEST= line, which you left empty. Hitting the CQ button.
9 years, 1 month ago (2011-10-24 21:28:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8381022/1
9 years, 1 month ago (2011-10-24 21:28:12 UTC) #3
commit-bot: I haz the power
Commit queue patch verification failed without an error message. Something went wrong, probably a crash, ...
9 years, 1 month ago (2011-10-24 21:47:58 UTC) #4
Mark Mentovai
LGTM
9 years, 1 month ago (2011-10-24 22:01:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8381022/4001
9 years, 1 month ago (2011-10-24 22:01:39 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-10-24 23:47:30 UTC) #7
Change committed as 107014

Powered by Google App Engine
This is Rietveld 408576698