Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: net/base/x509_certificate.h

Issue 8381017: net: retain leading zero bytes in X.509 serial numbers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/crl_set.cc ('k') | net/base/x509_certificate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate.h
diff --git a/net/base/x509_certificate.h b/net/base/x509_certificate.h
index b4677d23744bddafe510971dc2a81e9e1bdf525a..057e6aaccad50228d43a7e72ab52ea66dea94a9d 100644
--- a/net/base/x509_certificate.h
+++ b/net/base/x509_certificate.h
@@ -424,12 +424,7 @@ class NET_EXPORT X509Certificate
CRLSet* crl_set,
CertVerifyResult* verify_result) const;
- // The serial number, DER encoded.
- // NOTE: keep this method private, used by IsBlacklisted only. To simplify
- // IsBlacklisted, we strip the leading 0 byte of a serial number, used to
- // encode a positive DER INTEGER (a signed type) with a most significant bit
- // of 1. Other code must not use this method for general purpose until this
- // is fixed.
+ // The serial number, DER encoded, possibly including a leading 00 byte.
const std::string& serial_number() const { return serial_number_; }
// IsBlacklisted returns true if this certificate is explicitly blacklisted.
« no previous file with comments | « net/base/crl_set.cc ('k') | net/base/x509_certificate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698