src/x64/builtins-x64.cc - Issue 8381014: Fixing dead code in empty array init.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 8381014: Fixing dead code in empty array init. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Ported change to MIPS. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index 8baa2f32ff28eaffbf0c474ad4f27a84c633fba5..c048c2edaad0515aeeee76e6063b1bf2e14050c5 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -1075,6 +1075,7 @@ static void AllocateEmptyJSArray(MacroAssembler* masm,

}

} else {

Label loop, entry;

+ __ addq(scratch1, Immediate(FixedArray::kHeaderSize - kHeapObjectTag));

Kevin Millikin (Chromium) 2011/10/27 10:35:54 No need to untag here. Could use a counted loop s

__ jmp(&entry);

__ bind(&loop);

__ movq(Operand(scratch1, 0), scratch3);

« src/mips/builtins-mips.cc ('K') | « src/mips/builtins-mips.cc ('k') | no next file » | no next file with comments »