Issue 8381009: Const-ify DownloadStatusUpdaterDelegate methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8381009: Const-ify DownloadStatusUpdaterDelegate methods. (Closed)

Created:
9 years, 2 months ago by cbentzel

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, Randy Smith (Not in Mondays), Paweł Hajdan Jr.

CC:
chromium-reviews, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Const-ify DownloadStatusUpdaterDelegate methods. Also add OVERRIDEs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107159

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -25 lines)			Patch
M	content/browser/download/download_manager.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	content/browser/download/download_manager.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	content/browser/download/download_status_updater.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/download/download_status_updater.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/download/download_status_updater_delegate.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	content/browser/download/download_status_updater_unittest.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cbentzel

This was a pretty straightforward refactoring I decided to do while browsing some code. phajdan.jr: ...

9 years, 2 months ago (2011-10-24 15:18:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/8381009/1

9 years, 2 months ago (2011-10-25 16:08:27 UTC) #4

Change committed as 107159

Expand Messages | Collapse Messages