Issue 8381003: Fix crash in partial snapshot test when running with no boot snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8381003: Fix crash in partial snapshot test when running with no boot snapshot. (Closed)

Created:
9 years, 2 months ago by Erik Corry

Modified:
9 years, 2 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix crash in partial snapshot test when running with no boot snapshot. Committed: http://code.google.com/p/v8/source/detail?r=9755

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/serialize.cc	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

9 years, 2 months ago (2011-10-24 12:06:58 UTC) #2

LGTM

http://codereview.chromium.org/8381003/diff/1/src/serialize.cc
File src/serialize.cc (right):

http://codereview.chromium.org/8381003/diff/1/src/serialize.cc#newcode760
src/serialize.cc:760: Address address) {
When is address passed as NULL?
Why?
I.e., please put some documentation on this function in the .h file - at least
what the parameters mean and what values they may assume.

http://codereview.chromium.org/8381003/diff/1/src/serialize.cc#newcode808
src/serialize.cc:808: Address address = external_reference_decoder_->           
        \
Could we call this variable something else, so it doesn't have the same name as
the function parameter.

Expand Messages | Collapse Messages