ui/gfx/gl/gl_context_cgl.cc - Issue 8381001: Split GL binding init into core and extension part

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/gl/gl_context_cgl.cc

Issue 8381001: Split GL binding init into core and extension part (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Added dependencies to gl.gyp. Used NOT_REACHED() instead of DCHECK(0). Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/gl/gl_context_cgl.cc

diff --git a/ui/gfx/gl/gl_context_cgl.cc b/ui/gfx/gl/gl_context_cgl.cc

index 0e96bd4837904a9d98370a8bdc339f98e74dc2a6..879060221beaf4b55509757467c8a3b678e251bc 100644

--- a/ui/gfx/gl/gl_context_cgl.cc

+++ b/ui/gfx/gl/gl_context_cgl.cc

@@ -103,6 +103,11 @@ bool GLContextCGL::MakeCurrent(GLSurface* surface) {

}

SetCurrent(this, surface);

+ if (!InitializeExtensionBindings()) {

+ ReleaseCurrent(surface);

+ return false;

+ }

if (!surface->OnMakeCurrent(this)) {

LOG(ERROR) << "Unable to make gl context current.";

return false;

« no previous file with comments | « ui/gfx/gl/gl_context.cc ('k') | ui/gfx/gl/gl_context_egl.cc » ('j') | no next file with comments »