Issue 8380033: aura: Fix shift/ctrl/alt keyevents with RWHVA and X11.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8380033: aura: Fix shift/ctrl/alt keyevents with RWHVA and X11. (Closed)

Created:
9 years, 2 months ago by sadrul

Modified:
9 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, dhollowa, Emmanuel Saint-loubert-Bié

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

aura: Fix shift/ctrl/alt keyevents with RWHVA and X11. One of the functions didn't really do what it claimed it did. This ended up causing problems where pressing just the shift key (or the ctrl or alt key) would cause some garbage character to show up. BUG=101440 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107141

Patch Set 1 : . #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -29 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/web_input_event_aurax11.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_gtk.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_x.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_x.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	views/events/event_x.cc	View	3 chunks	+4 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages