Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 8380022: Fix the file_util_unittests.cc for Android (Closed)

Created:
9 years, 2 months ago by michaelbai
Modified:
9 years, 2 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix the file_util_unittests.cc for Android BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107020

Patch Set 1 : Init #

Total comments: 1

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/file_util_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaelbai
Hi Mark, This is a simple CL to fix the unit test for Android, since ...
9 years, 2 months ago (2011-10-24 22:06:16 UTC) #1
Mark Mentovai
What error occurs without this? It may be correct to #include <algorithm> unconditionally, or at ...
9 years, 2 months ago (2011-10-24 22:09:08 UTC) #2
michaelbai
On 2011/10/24 22:09:08, Mark Mentovai wrote: > What error occurs without this? It may be ...
9 years, 2 months ago (2011-10-24 22:15:36 UTC) #3
Mark Mentovai
http://codereview.chromium.org/8380022/diff/2001/base/file_util_unittest.cc File base/file_util_unittest.cc (right): http://codereview.chromium.org/8380022/diff/2001/base/file_util_unittest.cc#newcode14 base/file_util_unittest.cc:14: #include <algorithm> unconditionally here. set_union is supposed to be ...
9 years, 2 months ago (2011-10-24 22:17:07 UTC) #4
michaelbai
included <algorithm> unconditionally PTAL
9 years, 2 months ago (2011-10-24 22:23:35 UTC) #5
Mark Mentovai
LGTM
9 years, 2 months ago (2011-10-24 22:23:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/8380022/3003
9 years, 2 months ago (2011-10-24 22:32:12 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 00:08:29 UTC) #8
Change committed as 107020

Powered by Google App Engine
This is Rietveld 408576698