Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 8380017: Add and use ElementsKind side effect (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 732 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 743
744 LInstruction* LChunkBuilder::MarkAsCall(LInstruction* instr, 744 LInstruction* LChunkBuilder::MarkAsCall(LInstruction* instr,
745 HInstruction* hinstr, 745 HInstruction* hinstr,
746 CanDeoptimize can_deoptimize) { 746 CanDeoptimize can_deoptimize) {
747 #ifdef DEBUG 747 #ifdef DEBUG
748 instr->VerifyCall(); 748 instr->VerifyCall();
749 #endif 749 #endif
750 instr->MarkAsCall(); 750 instr->MarkAsCall();
751 instr = AssignPointerMap(instr); 751 instr = AssignPointerMap(instr);
752 752
753 if (hinstr->HasSideEffects()) { 753 if (hinstr->HasObservableSideEffects()) {
754 ASSERT(hinstr->next()->IsSimulate()); 754 ASSERT(hinstr->next()->IsSimulate());
755 HSimulate* sim = HSimulate::cast(hinstr->next()); 755 HSimulate* sim = HSimulate::cast(hinstr->next());
756 instr = SetInstructionPendingDeoptimizationEnvironment( 756 instr = SetInstructionPendingDeoptimizationEnvironment(
757 instr, sim->ast_id()); 757 instr, sim->ast_id());
758 } 758 }
759 759
760 // If instruction does not have side-effects lazy deoptimization 760 // If instruction does not have side-effects lazy deoptimization
761 // after the call will try to deoptimize to the point before the call. 761 // after the call will try to deoptimize to the point before the call.
762 // Thus we still need to attach environment to this call even if 762 // Thus we still need to attach environment to this call even if
763 // call sequence can not deoptimize eagerly. 763 // call sequence can not deoptimize eagerly.
764 bool needs_environment = 764 bool needs_environment =
765 (can_deoptimize == CAN_DEOPTIMIZE_EAGERLY) || !hinstr->HasSideEffects(); 765 (can_deoptimize == CAN_DEOPTIMIZE_EAGERLY) ||
766 !hinstr->HasObservableSideEffects();
766 if (needs_environment && !instr->HasEnvironment()) { 767 if (needs_environment && !instr->HasEnvironment()) {
767 instr = AssignEnvironment(instr); 768 instr = AssignEnvironment(instr);
768 } 769 }
769 770
770 return instr; 771 return instr;
771 } 772 }
772 773
773 774
774 LInstruction* LChunkBuilder::MarkAsSaveDoubles(LInstruction* instr) { 775 LInstruction* LChunkBuilder::MarkAsSaveDoubles(LInstruction* instr) {
775 instr->MarkAsSaveDoubles(); 776 instr->MarkAsSaveDoubles();
(...skipping 1432 matching lines...) Expand 10 before | Expand all | Expand 10 after
2208 2209
2209 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2210 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2210 LOperand* key = UseRegisterAtStart(instr->key()); 2211 LOperand* key = UseRegisterAtStart(instr->key());
2211 LOperand* object = UseRegisterAtStart(instr->object()); 2212 LOperand* object = UseRegisterAtStart(instr->object());
2212 LIn* result = new LIn(key, object); 2213 LIn* result = new LIn(key, object);
2213 return MarkAsCall(DefineFixed(result, r0), instr); 2214 return MarkAsCall(DefineFixed(result, r0), instr);
2214 } 2215 }
2215 2216
2216 2217
2217 } } // namespace v8::internal 2218 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698